Add GRPCServiceLifecycle module
#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Jan 17, 2025
| public import GRPCCore | ||
| public import ServiceLifecycle | ||
|
|
||
| extension GRPCClient: @retroactive Service { |
There was a problem hiding this comment.
nit: can you drop a comment in why @retroactive is okay here? (and for the server)
|
|
||
| // Retroactive conformances of gRPC client and server to swift-server-lifecycle's Service. | ||
| .target( | ||
| name: "GRPCServiceLifecycle", |
There was a problem hiding this comment.
It'd be great if you could add a documentation bundle for this too (and update .spi.yml). That can be a follow up though if you prefer.
There was a problem hiding this comment.
Hm, looks like none of the modules other than the Health service actually have a doc bundle so maybe we should do that separately for all?
glbrntt
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new module adds conformances to the
Serviceprotocol fromgrpc-swift-service-lifecycletoGRPCClientandGRPCServerso that they compose nicely withServiceLifecycle.Note: depends on grpc/grpc-swift#2166